Fallback to default while reading MIDR_EL1 sysfs #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/sysfs is inaccessible while running in AWS Lambda environment, or might be empty if executed inside container on Apple Silicon
|
This time I run |
|
Thank you for the patch! |
sandye51
reviewed
Dec 19, 2023
| @@ -440,12 +440,16 @@ class CpuInfoLinux : public CpuInfo { | |||
|
|
|||
| FILE *file = fopen(path_midr_el1, "r"); | |||
| if (file == nullptr) { | |||
| throw Error(ERR_INTERNAL); | |||
| // sysfs is unaccessible for AWS Lambdas | |||
| fprintf(stderr, "%s, %d: Can't open MIDR_EL1 sysfs entry\n", __FILE__, __LINE__); | |||
There was a problem hiding this comment.
I suppose printf is not needed here, because this code is used in production where such messages are not allowed
There was a problem hiding this comment.
@sandye51
Thank you for the comment.
How about printfing only when the environment variable XBYAK_AARCH64_VERBOSE is defined?
There was a problem hiding this comment.
@sandye51 hmm, isn't it the same behavior as one allowed by XBYAK_AARCH64_ERROR_
xbyak_aarch64/src/util_impl_linux.h
Line 51 in f43f7e8
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sysfsis inaccessible while running in AWS Lambda environment, or might be empty if executed inside container on Apple SiliconFound while debugging pytorch/pytorch#115482 to be cherry-picked into oneDNN later