Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aarch64] cherry-pick Xbyak crash fix and linter error fixes from main #1649

Merged
merged 4 commits into from
Jan 3, 2024
Merged

[aarch64] cherry-pick Xbyak crash fix and linter error fixes from main #1649

merged 4 commits into from
Jan 3, 2024

Conversation

snadampal
Copy link
Contributor

@snadampal snadampal commented Dec 21, 2023 •
edited
Loading

cc: @atalman

snadampal and others added 4 commits December 21, 2023 13:26
@snadampal
cleanup mkldnn patching (pytorch#1630)
7fcad58 
pytorch is moved to oneDNN v3.3.2 and some of the
 old patches are not applicable any more.
@malfet @snadampal
Add aarch64_linux to the list of linted files
cf401be
@malfet @snadampal
Actually fix lint this type
dc101d7
@snadampal
aarch64: patch mkl-dnn for xbyak crashes due to /sys not accessible
898614f 
There are platforms with /sys not mounted. skip handling HW caps
for such platforms.

cherry-pick of: oneapi-src/oneDNN#1773
This fixes the issue# pytorch/pytorch#115482
@snadampal snadampal mentioned this pull request Dec 21, 2023
Closed
malfet
malfet requested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a cherry-pick of above-mentioned commit, is it?

@snadampal
Copy link
Contributor Author

hi @malfet this is a cherrypick of 4 commits from main. I picked all 4 so that they apply cleanly.
do you mean (1) let's pick only the last one and rework it to apply on 2.2 branch? or
(2) pick only the subset of changes went into xbyak repo? fujitsu/xbyak_aarch64#96

@atalman
Copy link
Contributor

atalman commented Dec 28, 2023

@snadampal Could you please mention all 4 cherry-picks in the issue tracker here: pytorch/pytorch#115300 (comment) this way we are sure which commits are getting cherry-picked

@snadampal
Copy link
Contributor Author

Hi @malfet , @atalman , updated the tracker with all the 4 commits.

@malfet malfet merged commit 68a5236 into pytorch:release/2.2 Jan 3, 2024
2 checks passed
@atalman atalman mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snadampal @atalman @malfet @facebook-github-bot