Fixes for various issues (PropTypes in Polygon, GoogleAPI verison, ClickableMarkers not bool) #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2017
|
fixes #120 |
|
This PR seems to reverse the fix for isomorphic apps in dist/lib/GoogleApi.js. There are a couple of other places that need fixes to permit serverside rendering that I have come across too. |
|
Is this going to be merged soon? I'd love to clean up my console. |
jaysanatez
reviewed
Oct 20, 2017
src/index.js
Outdated
| @@ -143,7 +143,7 @@ export class Map extends React.Component { | |||
| zoom: this.props.zoom, | |||
| maxZoom: this.props.maxZoom, | |||
| minZoom: this.props.maxZoom, | |||
| clickableIcons: this.props.clickableIcons, | |||
| clickableIcons: this.props.clickableIcons || false, | |||
There was a problem hiding this comment.
It's probably simpler to change it to !!this.props.clickableIcons. The !! syntax coerces truthy/falsy values (null, 0, 1, a valid object) into boolean type true/false values, so they will match the expected type bool - i.e. null and 0 become false, 1 or {...} becomes true
|
Updated thanks @jaysanatez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.