-
Notifications
You must be signed in to change notification settings - Fork 813
Circle support #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle support #258
Conversation
This Circle component works, however, it appears it's missing the componentWillReceiveProps event handling, so that when center changes it doesn't redraw. I have to refresh the browser to make it redraw. |
The circle is now re-rendered on any prop change among props defined in |
This works great. Thank you very much! Why not release it? |
I don't have merge access for this repo, so all I can do is submit a pull request and wait for it to be reviewed. @auser Is anyone available to review this? |
Thanks! It’s perfect |
No problem, thanks for making this module. It's great! |
Just tried and it seems the lastest 2.0.2 doesn't work.
…On Sun, Oct 7, 2018 at 10:19 PM Ryan Oboril ***@***.***> wrote:
No problem, thanks for making this module. It's great!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#258 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEsr4xydZNOVFEFJxi_XTfYFM1PimTvjks5uisQpgaJpZM4W1j68>
.
|
@auser |
It appears the circles in 2.0.2 is working now. |
Sorry, I spoke a little too early...it is strange that it works fine in dev mode, but not in production mode - I got "Minified react error #130". |
I've tried a few of the existing pull requests for this functionality and they did not work for me. I have re-added the functionality myself in the hopes that this can be merged. I have included a screenshot and some example code in the README. Let me know what else needs to be done to get this in.