Skip to content

Fix Marker Component #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

basantech89
Copy link
Contributor

Details

Fix: #406

Fix Marker Component
Below is the screenshot:-
2020-01-21-1579585934_screenshot_1366x768

Completed?: (Yes)

@auser auser merged commit dabc6e8 into fullstackreact:master Feb 5, 2020
@NickFoden
Copy link
Contributor

Wait @basantech89 @auser I think this might be a mistake.

This returns null instead of a marker ?

image

Copy link
Contributor

@NickFoden NickFoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow this. This is removing it entirely? I don't think this is a fix.

@auser
Copy link
Contributor

auser commented Feb 5, 2020

Oops! I may have included that when I intended on commenting instead.

}
</Fragment>
)
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this entirely?

@NickFoden
Copy link
Contributor

Yeah @auser I think revert this. OP may need to pass the markers in a different format for their needs.

@basantech89 this is how i render markers make sure you have all the required props for your markers that could be the reason you don't have working markers. Ping me with your code if you are unable to render markers on your map.

this.props.locationMarkers.map((item, index) => {
return (
<Marker
   key={index}
   id={index}
   icon={MapMarker}
   position={{
      lat: item.lat,
      lng: item.lng
      }}
    name={item.address ? item.address : ""}
    url={`rental-listing/${item.url}`}
    onClick={this.onMarkerClick}
/>

imladenov1997 added a commit to imladenov1997/google-maps-react that referenced this pull request Apr 3, 2020
…ech89-issue407"

This reverts commit dabc6e8, reversing
changes made to e8c29b3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest build breaks the Marker component
3 participants