Skip to content

v0.1.5

Choose a tag to compare

@ehsan6sha ehsan6sha released this 29 Jan 18:22
· 215 commits to main since this release

Full Changelog: v0.1.4...v0.1.5

Fixed remaining concerns for audit:
In [M-02], you have added the GAS_BUFFER of 20_000 gas but it was not used. When the variable isn't used for checking the gas left or anything, it's better to remove it.
Status: Fixed
Solution: removing the unused GAS_BUFFER as the loop was removed and no longer a problem of gas consumption
commit: c7a918f

In [M-03], The Admin can still revokeRole by using renounceRole() function that was inhertied from AccessControl. -- and it doesn't care about adminCount. So fix it accordingly.
Status: Fixed
Solution: Added renounceRole override and checking hte remaining admins
commit: cf2ed2a

In [L-01], The Constructor is still payable -- which means, the Lock contract can be still deployed with some amount of ETH -- either add a function to remove the ETH that was sent during deployment or remove payable keyword (as it doesn't save much gas compared to losing ETH while deployment).
Status: Fixed
Solution: Removed payable
commit: be794de