86 set java build version in only one place #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umber in pom.xml file pom.xml file now contains maven.compiler.release instead of maven.compiler.source/target. yml files now reads pom.xml file and saves the maven.compiler.release number in a variable and uses that variable when choosing what java version to use.
…umber in pom.xml file pom.xml file now contains maven.compiler.release instead of maven.compiler.source/target. yml files now reads pom.xml file and saves the maven.compiler.release number in a variable and uses that variable when choosing what java version to use.
|
Kudos, SonarCloud Quality Gate passed!
|
kappsegla
approved these changes
Feb 15, 2023
wassimtajeddin
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to update multiple files to upgrade our java version, now we only need to do it in our pom.xml file. In pom.xml we now use maven.compiler.release instead of maven.compiler.source and .target. In our yml files they now read our pom.xml file and saves the number defined in our maven.compiler.release, saves it to a enviroment variable and then uses it to define what java version we want.
This only works in default branch, which is why i tried in another project.
Here we see that the command is run to save the java version, and also that set up jdk uses java 19 which is our expected result.