Adding Anisotropy and Clear coat to PBR material #523
Conversation
|
Hello @guaje! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-01-28 19:08:48 UTC |
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 82.11% 82.40% +0.29%
==========================================
Files 54 54
Lines 10628 10997 +369
Branches 1061 1080 +19
==========================================
+ Hits 8727 9062 +335
- Misses 1641 1670 +29
- Partials 260 265 +5
|
…th and roughness parameters to both the material module and the tutorial.
…z_pbr_spheres tutorial.
|
Hi @guaje, This is release week for FURY. What is the status of this PR? Will you be able to finish it? |
| from fury.utils import set_input | ||
|
|
||
|
|
||
| def load_cubemap_texture(fnames, interpolate_on=True, mipmap_on=True): |
There was a problem hiding this comment.
this function can be useful for our actors. after merging, we should create an issue to remove duplicate
docs/examples/viz_pbr_interactive.py
Outdated
| the rendering of the skybox. | ||
| """ | ||
|
|
||
| scene = window.Scene(skybox_tex=cubemap, render_skybox=True) |
There was a problem hiding this comment.
I would use one parameter. Can you explain why two parameters are necessary?
There was a problem hiding this comment.
I will add an issue to remove the skybox since that might require extra functionality to notify the actors they should not use IBL anymore.
The update skybox should be easier since the light information is only calculated when we render the scene. However, I think this should come in a future PR too.
docs/examples/viz_pbr_interactive.py
Outdated
| def change_slice_anisotropy_rotation(slider): | ||
| global pbr_params, sphere | ||
| pbr_params['anisotropy_rotation'] = slider.value | ||
| sphere.GetProperty().SetAnisotropyRotation( |
There was a problem hiding this comment.
@guaje For such functions we will need utility functions in material.py
|
Nice work, Thank you a lot for pushing @guaje! merging |
This PR adds the latest material modeling capabilities supported by VTK (see all the references here). In particular, this PR focuses on adding functions to model anisotropic materials (see more here) and adding a clear coat on top of an actor (see more here).
Here is a screenshot of the included tutorial:
And here is a gif of the included interactive demo: