Channels: Open, List & Close #82
Conversation
|
This pull request introduces 4 alerts when merging 2ce10c6 into ce7f82c - view on LGTM.com new alerts:
|
|
@fusion44 please check this PR for merging so that @cstenglein can use it for the WebUI channel management |
app/models/lightning.py
Outdated
|
|
||
| @classmethod | ||
| def from_grpc_pending(cls, c) -> "Channel": | ||
| print(str(c)) |
There was a problem hiding this comment.
thats needed and in use ... its to parse channel info from grpc opening pending channels objects, that are slightly different from already active channels - so a special parsing method was needed
There was a problem hiding this comment.
ah Ok - thats gone now
app/repositories/ln_impl/lnd.py
Outdated
| try: | ||
| await lncfg.lnd_stub.ConnectPeer(r) | ||
| #print("CONNECTED TO PEER") | ||
| #print(str(pubkey)) |
There was a problem hiding this comment.
These commented out print statements could be removed.
There was a problem hiding this comment.
should be removed now
app/repositories/ln_impl/lnd.py
Outdated
| async for response in lncfg.lnd_stub.CloseChannel(request): | ||
| #print(str(response)) | ||
| # TODO: this is still some bytestring that needs correct convertion to a string txid (ok OK for now) | ||
| return str(response.close_pending.txid) |
There was a problem hiding this comment.
I think response.close_pending.txid.hex() should do the trick.
There was a problem hiding this comment.
testing with hex() now
There was a problem hiding this comment.
ok looks good on first test
implementation just for LND - core lightning still throws an NOT IMPELEMENTED error