Skip to content

Conversation

deshipu
Copy link
Contributor

@deshipu deshipu commented Sep 18, 2014

In 1.3 they removed some names from init, so we have to
import them from their corresponding modules inside pyscss.

In 1.3 they removed some names from __init__, so we have to
import them from their corresponding modules inside pyscss.
@deshipu
Copy link
Contributor Author

deshipu commented Sep 18, 2014

I made this pull request just so that we have a working version, but we don't need that at OpenStack anymore, as the fix in PyScss 1.3 was backported to 1.2 and we can use that.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.38%) when pulling 9b8d071 on deshipu:master into 138310d on fusionbox:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deshipu,

I think the syntax for this is different unfortunately. Some of the environments will miss be installed without Django.

@acatton
Copy link
Contributor

acatton commented Oct 17, 2014

Is this still relevant after 9f27a0e and 2c5dd9d?

@rockymeza
Copy link

@deshipu, PyScss 1.3 has introduced some major changes which most likely broke everything we were doing. You can see the discussion for that at Kronuz/pyScss#265.

In great open source awesomeness. I hope that we will have a new version of django-pyscss that supports both versions in the next couple of weeks.

@rockymeza rockymeza closed this Oct 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants