Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Conversation

alxmyth
Copy link
Member

@alxmyth alxmyth commented May 12, 2018

#### Problem/Rationale

Fusion.js packages, with the exception of `fusion-core` do not export [libdef](https://flow.org/en/docs/libdefs/) and consumers rely on the Flow type definitions embedded in the source code.  Given this, it is a pain point for consumers when type definitions are missing or incomplete.

We should also strive for full Flow coverage to minimize issues within our own packages.

#### Solution/Change/Deliverable

Two-fold:
* Reach 100% Flow coverage on exported type definitions.
* Strive for 100% Flow coverage internally for each package.

screen shot 2018-05-11 at 5 23 45 pm

(compare to before)

@alxmyth alxmyth self-assigned this May 12, 2018
@codecov
Copy link

codecov bot commented May 12, 2018

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files           2        2           
  Lines          27       27           
  Branches        4        4           
=======================================
  Hits           26       26           
  Partials        1        1
Impacted Files Coverage Δ
src/plugin.js 100% <ø> (ø) ⬆️
src/hoc.js 94.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f53f03...7d38166. Read the comment docs.

KevinGrandon
KevinGrandon previously approved these changes May 12, 2018
mapStateToParams,
}: {
propName?: string,
transformParams?: (params: any) => any,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using * any better in these cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, I think it would be. Since we don't necessarily care what the input is as long as it matches the needs of withRPCRedux (a la, go ahead and infer that type and enforce whatever you infer). It does look like the existential type may soon fall out of favor as of 0.0.72 though.

In either case, coverage won't change here. The inferred type will be any as that's what fusion-rpc-redux currently expects.

@alxmyth alxmyth merged commit b02fea3 into fusionjs:master May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants