Add runtime to Episode #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruinernin
added a commit
to ruinernin/script.trakt
that referenced
this pull request
Oct 26, 2019
TVDB does not provide runtime metadata for episodes. If this can not then be filled by Kodi introspecting the file for the item (e.g. library item that is a .STRM file) the info label will be `0`. Meaning the resume position set by Trackt will be `0` as the calculation is `runtime * progress_pct`. Episode runtime metadata exists in the metadata provided by Trakt for episodes so this can be queried in these cases to calculate a resume time that is reasonably accurate. This depends on fuzeman/trakt.py#69 being merged and propagated to Razzeee/script.module.trakt
ruinernin
added a commit
to ruinernin/script.trakt
that referenced
this pull request
Oct 26, 2019
TVDB does not provide runtime metadata for episodes. If this can not then be filled by Kodi introspecting the file for the item (e.g. library item that is a .STRM file) the info label will be `0`. Meaning the resume position set by Trackt will be `0` as the calculation is `runtime * progress_pct`. Episode runtime metadata exists in the metadata provided by Trakt for episodes so this can be queried in these cases to calculate a resume time that is reasonably accurate. This depends on fuzeman/trakt.py#69 being merged and propagated to Razzeee/script.module.trakt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.