Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up process management logic #2205

Merged
merged 19 commits into from
Nov 29, 2023
Merged

refactor: clean up process management logic #2205

merged 19 commits into from
Nov 29, 2023

Conversation

fwouts
Copy link
Owner

@fwouts fwouts commented Nov 9, 2023

This should help fix various issues on Windows such as:

  • terminal window popping up when starting preview (& closing it kills the preview server)
  • process keeps running on Windows when VS Code is closed, preventing cleanup of resources
  • race condition bugs when using multiple VS Code windows on Mac

@fwouts fwouts marked this pull request as ready for review November 29, 2023 10:54
@fwouts fwouts merged commit d5b9676 into main Nov 29, 2023
18 checks passed
@fwouts fwouts deleted the windows-improvements branch November 29, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fwouts