Skip to content

Conversation

JohanLorenzo
Copy link
Contributor

I ran into these logs:

[2016-04-18 15:58:05.323] (6618) INFO  [Recipe 'Turn off the lights when I leave for work.'] Starting compilation of script.
[2016-04-18 15:58:05.324] (6681) INFO  [Recipe 'Turn off the lights when I leave for work.'] Compilation succeeded.
[2016-04-18 15:58:05.324] (6681) INFO  [Recipe 'Turn off the lights when I leave for work.'] Starting execution of script
[2016-04-18 15:58:05.324] (6681) INFO  [Recipe 'Turn off the lights when I leave for work.'] Initializing rule 0 condition 0. Currently, it can listen to 1 channels.
[2016-04-18 15:58:05.327] (6681) INFO  [Recipe 'Turn off the lights when I leave for work.'] Initializing rule 0 condition 1. Currently, it can listen to 1 channels.
[2016-04-18 15:58:05.327] (6681) INFO  [Recipe 'Turn off the lights when I leave for work.'] Initialization error for getter:power.2.001788fffe243568.philips_hue@link.mozilla.org: Attempting to watch a value from a Channel<Getter> that doesn't support this operation: getter:power.2.001788fffe243568.philips_hue@link.mozilla.org

I didn't immediately notice that there was an error hidden in there. Here's a small patch to prevent that from happening again.

r? @Yoric

@Yoric
Copy link
Collaborator

Yoric commented Apr 18, 2016

I'd prefer if it were a warn rather than an error, but wfm.

@JohanLorenzo
Copy link
Contributor Author

I think that's technically an error: the operation requested (aka "create a new rule") failed, I wasn't able to see it in the UI. A warn is more appropriated when the operation recovered and managed to create the rule anyway (like with a default value).

What do you think @Yoric ?

@Yoric
Copy link
Collaborator

Yoric commented Apr 18, 2016

Well, it's a user error, rather than a foxbox error, and I think that we need to make a difference between both. A custom macro would probably be useful. In the meantime, I'd say that it's a warn, but I'm not going to insist strongly.

@JohanLorenzo
Copy link
Contributor Author

My bad, I didn't realize it's a user error. I changed it to warn

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2f89b76 on JohanLorenzo:log-level-init into * on fxbox:master*.

@JohanLorenzo JohanLorenzo merged commit 5225d90 into fxbox:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants