Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changing properties, scale images and other improvements #8

Merged
merged 5 commits into from
May 4, 2022
Merged

Fix changing properties, scale images and other improvements #8

merged 5 commits into from
May 4, 2022

Conversation

dhaavi
Copy link

@dhaavi dhaavi commented May 4, 2022 •
edited
Loading

  • Advertise that we may write icon pixmal/title/tooltip
  • Set values as props.Properties.Set when setting
  • Save properties to instance
  • Improve logging and log messages
  • Fix linter warnings
  • Add support for auto-scaling images

@dhaavi dhaavi mentioned this pull request May 4, 2022
Closed
andydotxyz
andydotxyz requested changes May 4, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the tidies.
Just not sure about that new public global variable.

systray_unix.go Outdated Show resolved Hide resolved
@andydotxyz andydotxyz mentioned this pull request May 4, 2022
Closed
@dhaavi dhaavi requested a review from andydotxyz May 4, 2022 20:23
@andydotxyz
Copy link
Member

Thanks for this. In the future please don't force push once review has been done - just makes it a little harder to review ongoing.

andydotxyz
andydotxyz approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this and keeping things clean!

@andydotxyz andydotxyz merged commit 28f121f into fyne-io:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaavi @andydotxyz