Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented protection apply and delete commands #71

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

orlovm
Copy link
Collaborator

@orlovm orlovm commented May 19, 2021

For #60 - implemented protection apply and delete commands.

Also added pull request review field to protection spec.

@orlovm
Copy link
Collaborator Author

orlovm commented May 25, 2021

@g4s8 please review PR!

@g4s8 g4s8 self-assigned this May 28, 2021
@g4s8 g4s8 self-requested a review May 28, 2021 09:16
Copy link
Owner

@g4s8 g4s8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlovm please check my comments

internal/gitstrap/apply.go Outdated Show resolved Hide resolved
internal/gitstrap/apply.go Outdated Show resolved Hide resolved
internal/gitstrap/delete.go Outdated Show resolved Hide resolved
internal/spec/protection.go Outdated Show resolved Hide resolved
internal/spec/protection.go Outdated Show resolved Hide resolved
internal/spec/protection.go Outdated Show resolved Hide resolved
@g4s8 g4s8 assigned orlovm and unassigned g4s8 May 28, 2021
@g4s8 g4s8 enabled auto-merge (squash) May 28, 2021 09:29
@orlovm orlovm requested a review from g4s8 May 31, 2021 20:44
@orlovm
Copy link
Collaborator Author

orlovm commented Jun 3, 2021

@g4s8 please, review changes.

@g4s8 g4s8 merged commit 47781ab into g4s8:master Jun 4, 2021
Copy link
Owner

@g4s8 g4s8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlovm thanks

@g4s8 g4s8 mentioned this pull request Jul 6, 2021
Closed
@orlovm orlovm deleted the 60-apply-branch-protection branch July 7, 2021 18:16
g4s8 added a commit that referenced this pull request Aug 3, 2021
 - feat(init): init commands to generate stub files (#81)
 - feature(delete): delete commands for teams, protections, readmes and hooks
 - feature(delete): delete repo command
 - refactoring(pagination): implemented pagination utils
 - docs(protections): added branch protection spec to wiki
 - fix(protections): protection ToGithub and FromGithub fixed
 - feature(protections): implemented protection apply and delete commands (#71)
 - deps: bump github.com/urfave/cli/v2 from 2.1.1 to 2.3.0 (#69)
 - ci: fixed dependabot config
 - docs(teams): Added wiki documentation for teams (#68)
 - ci: Added Github actcion to update wiki (#67)
 - feature(teams): Implemented apply and delete team commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants