DNAstack's Data Connect URL updates #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecommissioned Data Connect services with data.publisher.dnastack.com
shiroyuki
changed the title
…lem of running the query.
shiroyuki
changed the title
…nect-compatible services from DNAstack
shiroyuki
changed the title
…ble references to match the equivalent tables from the publisher data service.
jb-adams
approved these changes
Sep 28, 2023
|
hi @ianfore , this PR updates a notebook that was access data through our historical public data connect trino. We're decommissioning those services, so the notebook has been updated to use the equivalent services/datasets on our live platform. Is there any process for getting this PR reviewed, or are we free to merge? |
|
@ianfore @briandoconnor bumping this thread. Is there any process we need to follow for getting this PR merged? |
|
@briandoconnor @ianfore If there are no objections, I will merge this PR at the end of this week. |
|
Thanks @mbarkley @jb-adams @shiroyuki . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to replace all references to the decommissioned Data Connect service (
ga4gh-search-presto-adapter-public.prod.dnastack.com) and the soon-to-be-decommissioned Data Connect service (data-connect-trino-public.prod.dnastack.com). The new hostname ispublisher-data.prod.dnastack.com.Please be aware that all tables in the queries for the Data Connect services will be updated as well.