Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Adding documentation #242

Merged
merged 1 commit into from
Apr 20, 2015
Merged

Adding documentation #242

merged 1 commit into from
Apr 20, 2015

Conversation

adamnovak
Copy link
Contributor

I've added a doc folder with the Dia file for my ever-popular UML diagram.

I'm also adding a contrib folder with the Doxyfile and Python filter script I used to make the UML (via import of Doxygen XML files).

I'm updating GeneratingDocumentation.md to describe how to do this.

While I'm at it, I liked the simple build process of Doxygen, so I've put in a script contrib/make_avrodoc.sh to do all the steps specified in the markdown file, and documented its use.

@adamnovak
Copy link
Contributor Author

I know people in #243 want more documentation. Is this the right way to structure it?

@fnothaft
Copy link
Contributor

fnothaft commented Mar 2, 2015

This is great but I would really (strenuously?) like to see a few simple queries written out using the new API. E.g., what does a SNP/short INDEL look like in each representation? How do I walk the graph to find all variants within 10kbp of a specific site? etc.

@adamnovak
Copy link
Contributor Author

OK, I have added a "Graph Mode FAQ" markdown file, with the answers to these questions. I know it's incomplete, but if we throw it in, people can start making pull requests with questions they want answered, and we can keep all the answers in one place that's under revision control, instead of having them scattered across many issues and e-mail threads.

@adamnovak adamnovak force-pushed the doxygen branch 3 times, most recently from 358dfcd to 86a142b Compare March 2, 2015 20:08
@jeromekelleher
Copy link
Contributor

I like the idea of a graph mode FAQ, but please rename it to remove the spaces in the file name.

@pgrosu
Copy link
Contributor

pgrosu commented Mar 3, 2015

+1, the docs looks great and feel free to use images too instead of just ASCII-text figures. Not sure how many people will find generating the doc easy, but can you include a premade image of the UML diagram as well as the doxygen html outputs for the schemas/API?

@adamnovak
Copy link
Contributor Author

I'm reluctant to include the Doxygen HTML output, because I don't want to compete with Avrodoc. In fact, I told Doxygen not to generate HTML output, only the XML that Dia needs.

I have put the GeneratingDocumentation.md file in the doc folder now, and removed the spaces from the FAQ filename. I've also included an SVG of the UML, which more than just Dia can read.

@adamnovak
Copy link
Contributor Author

Any other comments on this? Any more questions for the FAQ?


There is a UML class diagram, `doc/uml.dia`, that describes the layout of the GA4GH data model.

UML class diagrams can be partially generated from the schemas by using [Doxygen](http://www.doxygen.org/) to generate XML, and then using [Dia](http://live.gnome.org/Dia) to generate a UML from that XML output. Unfortunately, this only imports the Avro types: dependencies and layout still need to be done manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amend this to allow for inclusion of .vsdx (Visio XML) diagrams as well as .dia?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not disallowing those, but I don't really have the right software to make one. I could throw in an exported .vdx from Dia if you would like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, that wasn't my intention. I think it makes perfect sense to include both the source file and the resulting SVG, as you did here. My only suggestion (perhaps better aimed at the CONTRIBUTING.md, now that I think about it) was to allow for optional future inclusion of .vsdx files if the creator had used a tool that natively supports them.

@delagoya
Copy link
Contributor

+1

Any other comments or suggestions?

Adding in Doxygen capabilities for generating UML.

Adding UML diagram.

Specifying how the UML diagram can be generated.

Automating Avrodoc build with a script.

Adding proper Beacon stuff to the UML

Updating UML to drop AlleleResource

Adding a Graph Mode FAQ

It would be good to have the answers to people's questions about graph mode
all in one place.

Moving and renaming documentation

All the extra Markdowns should go in doc/, and should not have spaces
in the filenames.

Adding an SVG of the UML to the repo.

Make the FAQ make sense with the side graph changes.
@adamnovak
Copy link
Contributor Author

I think this is mergable, since it has two +1s and I've addressed (to my own satisfaction) the other comments.

I've updated the Markdown files to reflect the side graph changes and rebased against master. The UML needs to be updated for side graphs, but I figure I (or someone else who has a better version of my UML-making process) can do that after this is in.

delagoya added a commit that referenced this pull request Apr 20, 2015
* Adding additional documentation capabilities using Doxy 
* Updated project documentation on how to generate the documentation artifacts
@delagoya delagoya merged commit a133693 into ga4gh:master Apr 20, 2015
@adamnovak adamnovak deleted the doxygen branch April 30, 2015 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants