Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load/Save #15

Merged
merged 10 commits into from
Jan 11, 2019
Merged

Load/Save #15

merged 10 commits into from
Jan 11, 2019

Conversation

gabyx
Copy link
Owner

@gabyx gabyx commented Jan 6, 2019

#11

@gabyx gabyx requested a review from simonspoerri January 6, 2019 20:01
@simonspoerri
Copy link
Collaborator

Selecting a file path in the client and transmitting that to the backend is not the "web" way of doing things. For security reasons we do not have access to the file path by default.
We could:

  • read the file in the client and transmit the file stream to the backend
  • read the file in the client and save it to a temporary file with a well known path, transmit this temporary path to the backend
  • add some electron (CEF) extension to read /select a file in electron including the file path
  • Find a way to change the security settings of the browser to allow reading the path of a selected file (not sure if that's possible)

I'd go for option 1 or 2

@gabyx gabyx merged commit c2b13b5 into dev Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants