fix(check-tag-names): if user targets aliases for renaming, these should have precedence over natural aliases

Author: brettz9

README.md

@@ -1232,6 +1232,15 @@ function quux (foo) {
 // Settings: {"jsdoc":{"tagNamePreference":{"param":"arg"}}}
 // Message: Invalid JSDoc tag (preference). Replace "param" JSDoc tag with "arg".
 
+/**
+ * @arg foo
+ */
+function quux (foo) {
+
+}
+// Settings: {"jsdoc":{"tagNamePreference":{"arg":"somethingDifferent"}}}
+// Message: Invalid JSDoc tag (preference). Replace "arg" JSDoc tag with "somethingDifferent".
+
 /**
  * @param foo
  */

src/jsdocUtils.js

@@ -65,15 +65,18 @@ const getPreferredTagName = (name : string, tagPreference : Object = {}) : strin
     return name;
   }
 
+  if (_.has(tagPreference, name)) {
+    return tagPreference[name];
+  }
+
   const preferredTagName = _.findKey(tagNames, (aliases) => {
     return aliases.includes(name);
   });
-
   if (preferredTagName) {
     return preferredTagName;
   }
 
-  return _.has(tagPreference, name) ? tagPreference[name] : name;
+  return name;
 };
 
 const isValidTag = (name : string, additionalTagNames : Object) : boolean => {

test/rules/assertions/checkTagNames.js

@@ -87,6 +87,29 @@ export default {
         }
       }
     },
+    {
+      code: `
+          /**
+           * @arg foo
+           */
+          function quux (foo) {
+
+          }
+      `,
+      errors: [
+        {
+          line: 3,
+          message: 'Invalid JSDoc tag (preference). Replace "arg" JSDoc tag with "somethingDifferent".'
+        }
+      ],
+      settings: {
+        jsdoc: {
+          tagNamePreference: {
+            arg: 'somethingDifferent'
+          }
+        }
+      }
+    },
     {
       code: `
           /**