Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom styles & fix test case #20

Closed
wants to merge 3 commits into from
Closed

allow custom styles & fix test case #20

wants to merge 3 commits into from

Conversation

ustccjw
Copy link

@ustccjw ustccjw commented Sep 7, 2015

  1. This PR is make custom styles possible.
    we can pass styles to component to customization style.
  2. test/linkClass has some trouble, fixed. (react / react-addons-test-utils upgrade: @0.14.0-rc1)

@ustccjw
Copy link
Author

ustccjw commented Sep 8, 2015

we can use css-loader?modules&localIdentName=[local]-[hash:base64:5] in dev, then we can base [local] to set our own styles.

@ustccjw
Copy link
Author

ustccjw commented Sep 10, 2015

@ustccjw ustccjw changed the title allow custom styles allow custom styles & fix test case Sep 11, 2015
@forivall
Copy link

@ustccjw you should always @ mention the maintainer when you update a pull request since they don't get automatically notified when you update the PR.

@gajus
Copy link
Owner

gajus commented Sep 12, 2015

I have seen the PR. I do not have time at the moment to review it and come back with a counter solution. In general, the proposed approach feels like a hack. I will think over the weekend how can this be achieved.

@gajus
Copy link
Owner

gajus commented Sep 16, 2015

@gajus gajus closed this Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants