Adds From<H160> trait to ValueOrArray<H160>

[CyMule]

Motivation

The trait From<H160> for ValueOrArray<H160> is not implemented which prevents compilation when using pub fn address<T: Into<ValueOrArray<Address>>>(self, address: T) -> Self for ethers_core::types::Filter.

Cargo.toml used in both examples:

[dependencies]
ethers = { git = "https://github.com/gakonst/ethers-rs" }
eyre = "0.6.8"
tokio = { version = "1", features = ["full"] }

Example that should compile but doesn't:

use ethers::prelude::*;
use eyre::Result;

fn main() -> Result<()> {
    let address = "0x1F98431c8aD98523631AE4a59f267346ea31F984".parse::<Address>()?;
    let _filter = Filter::new().address(address);
    Ok(())
}

Compilation error from trying to compile the example above:

error[E0277]: the trait bound `ValueOrArray<H160>: From<H160>` is not satisfied
   --> src/main.rs:6:41
    |
6   |     let _filter = Filter::new().address(address);
    |                                 ------- ^^^^^^^ the trait `From<H160>` is not implemented for `ValueOrArray<H160>`
    |                                 |
    |                                 required by a bound introduced by this call
    |
    = help: the following other types implement trait `From<T>`:
              <ValueOrArray<H256> as From<H160>>
              <ValueOrArray<H256> as From<H256>>
              <ValueOrArray<H256> as From<U256>>
    = note: required because of the requirements on the impl of `Into<ValueOrArray<H160>>` for `H160`

Full example that should compile and print the PoolCreated log for creating the APE/WETH Uniswap v3 pool:

use ethers::prelude::*;
use eyre::Result;
use std::sync::Arc;

#[tokio::main]
async fn main() -> Result<()> {
    let client = Provider::<Http>::try_from(
        "https://mainnet.infura.io/v3/c60b0bb42f8a4c6481ecd229eddaca27",
    )?;
    let client = Arc::new(client);

    let address = "0x1F98431c8aD98523631AE4a59f267346ea31F984".parse::<Address>()?;
    let filter = Filter::new()
        .address(address)
        .select(14403763)
        .event("PoolCreated(address,address,uint24,int24,address)");
    let logs = client.get_logs(&filter).await?;

    for log in logs {
        println!("{:?}", log);
    }

    Ok(())
}

Expected output from full example:

Log { address: 0x1f98431c8ad98523631ae4a59f267346ea31f984, topics: [0x783cca1c0412dd0d695e784568c96da2e9c22ff989357a2e8b1d9b2b4e6b7118, 0x0000000000000000000000004d224452801aced8b2f0aebe155379bb5d594381, 0x000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2, 0x0000000000000000000000000000000000000000000000000000000000000bb8], data: Bytes(b"\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0<\0\0\0\0\0\0\0\0\0\0\0\0\xacK=\xac\xb9\x14a \x9a\xe9\xd4\x1e\xc5\x17\xc2\xb9\xcb\x1b}\xaf"), block_hash: Some(0x7bd551cf0ccdb0a19591b9212b663af51b4b2591ad45f6fed094aa1e685b8d7a), block_number: Some(14403763), transaction_hash: Some(0x7e1cb512516337180d3542aadc815d1e8ff4084561847e2d602e2875fb7bcbc9), transaction_index: Some(1), log_index: Some(7), transaction_log_index: None, log_type: None, removed: Some(false) }

Actual output from full example is the same compilation error previously listed.

Cargo Version / Platform

cargo cargo 1.62.0-nightly (f63f23ff1 2022-04-28)
platform Darwin MacBook-Pro-4.local 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64 x86_64

Solution

Implement the From trait for ValueOrArray inside ethers-core/src/types/log.rs

impl From<H160> for ValueOrArray<H160> {
    fn from(src: H160) -> Self {
        ValueOrArray::Value(src)
    }
}

I'm new to rust so I'm not sure if there is a better way to do this, but it did resolve my issue. After adding this, both my examples aboved compiled and ran successfully.

PR Checklist

• Added Tests
• Added Documentation
• Updated the changelog

[mattsse]

lgtm

[CyMule]

I added From<Vec<H160>> trait to ValueOrArray<H160> along with two examples for the address function usage.