This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: Add openssl and rustls feature flags in ethers-middleware
#1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblique
force-pushed
the
fix-tls
branch
2 times, most recently
from
d7e390e
to
58bba8e
Compare
…act-abigen Without this fix, `rustls` was enabled by default even if user had `openssl` feature flag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was working on a project with requirement to use OpenSSL, so I added this:
But I noticed that
rustlswas still building.Solution
The problem was that
ethers-middlewarewas explicitly usingreqwestwithrustls-tlsenabled, so I addedrustlsandopensslfeature flags to it.PR Checklist