Prestwich/event no lifetime

[prestwich]

Depends on #2082

Motivation

FunctionCall and Event both are created by Contract types via similar APIs. However, Event had a lifetime and borrowed the client, while FunctionCall cloned the client.

Solution

This PR updates Event to work as FunctionCall does.

Old Style:

• Event<'a, M, D>

New Style:

• Event<B, M, D>

PR Checklist

• Added Tests
• Added Documentation
• Updated the changelog
• Breaking changes

[gakonst]

supportive of the concept, the base PR shoudl be ready to go once @mattsse takes a look

[gakonst]

dependency prs merged

[mattsse]

The elimination of lifetime is a good change imo.

[prestwich]

can't reproduce the CI failures locally :/

[prestwich]

this is ready for review. The current lint and doc failures seem to be unrelated? I can't reproduce locally either.

[DaniPopes]

this is ready for review. The current lint and doc failures seem to be unrelated? I can't reproduce locally either.

I tried compiling with the latest nightly (rustc 1.69.0-nightly (5b8f28453 2023-02-12)) and the compiler panics at random points

After a few attempts I got it to compile at least with clippy and it found the type parameter goes unused in function definition in ethers-solc: #2146

[gakonst]

Good with me, prefer generic over lifetime. CI issues unrelated. Thank you for pushing this thru James, keen to start making cracks at the new middleware little by little.