Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Iss1008 Interfaces for certs store #352

Merged
merged 7 commits into from
May 27, 2022
Merged

Iss1008 Interfaces for certs store #352

merged 7 commits into from
May 27, 2022

Conversation

Jimbo4794
Copy link
Member

No description provided.

Jimbo4794 added 3 commits May 25, 2022 10:54
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
@Jimbo4794 Jimbo4794 requested a review from Michael-Baylis May 25, 2022 10:08
Copy link
Member

@hobbit1983 hobbit1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certificate is mis-spelled in both parameter and method names within this class - since this is the API for the service it does need to be correct

Jimbo4794 added 2 commits May 25, 2022 13:03
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Copy link
Contributor

@Michael-Baylis Michael-Baylis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realised we will need add certs stuff to core manager to expose to the test

but other than that, only a few changes

Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
@Jimbo4794 Jimbo4794 merged commit c507aad into main May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants