This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Iss1008 Interfaces for certs store #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbit1983
reviewed
May 25, 2022
.../src/test/java/dev/galasa/framework/internal/dss/FrameworkDynamicStatusStoreServiceTest.java
Outdated
Show resolved
Hide resolved
hobbit1983
reviewed
May 25, 2022
...sa.framework/src/test/java/dev/galasa/framework/internal/creds/FrameworkCredentialsTest.java
Outdated
Show resolved
Hide resolved
hobbit1983
reviewed
May 25, 2022
...sa.framework/src/test/java/dev/galasa/framework/internal/creds/FileCredentialsStoreTest.java
Outdated
Show resolved
Hide resolved
hobbit1983
suggested changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
certificate is mis-spelled in both parameter and method names within this class - since this is the API for the service it does need to be correct
hobbit1983
reviewed
May 25, 2022
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Michael-Baylis
suggested changes
May 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised we will need add certs stuff to core manager to expose to the test
but other than that, only a few changes
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
...nt/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/ICertificateStoreService.java
Outdated
Show resolved
Hide resolved
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/IKeyStore.java
Show resolved
Hide resolved
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/IKeyStore.java
Outdated
Show resolved
Hide resolved
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/IKeyStore.java
Outdated
Show resolved
Hide resolved
galasa-parent/dev.galasa.framework/src/main/java/dev/galasa/framework/spi/IKeyStore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: James Davies <jdavies47@hotmail.co.uk>
Michael-Baylis
approved these changes
May 26, 2022
hobbit1983
approved these changes
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.