Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Build locally with a bash script #374

Merged
merged 8 commits into from
Nov 4, 2022
Merged

Build locally with a bash script #374

merged 8 commits into from
Nov 4, 2022

Conversation

techcobweb
Copy link
Contributor

  • Lots of javadoc warnings fixed
    • Only 100 left, and all of those are 'no description for parameter' or 'no description for thrown'
  • Added build-locally.sh

Currently it takes my machine 8 minutes. There must be something wrong as a result.

Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb techcobweb requested a review from Jimbo4794 November 2, 2022 15:54
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
@techcobweb techcobweb requested review from jadecarino and removed request for Jimbo4794 November 4, 2022 12:15
@jadecarino
Copy link
Contributor

jadecarino commented Nov 4, 2022

Hi Mike, I have ran your script and I am running into a problem. This is when running with --delta and no overrides.
I have attached the log in a text file as it's quite long. I don't think this is to do with your script, as it's the same error we saw the other day when just running the commands:

Plugin [id: 'dev.galasa.githash', version: '0.15.0', apply: false] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (could not resolve plugin artifact 'dev.galasa.githash:dev.galasa.githash.gradle.plugin:0.15.0')
  Searched in the following repositories:
    maven(https://galasadev-cicsk8s.hursley.ibm.com/main/maven/obr/)
    maven2(https://repo.maven.apache
[Framework build script output - no overrides.txt](https://github.com/galasa-dev/framework/files/9939525/Framework.build.script.output.-.no.overrides.txt)
.org/maven2/)
    Gradle Central Plugin Repository

Not sure if you get the same error or not? It might be good to understand why this happens, as otherwise people who run the script with no overrides will likely get this error.

I am also unsure what the second error is from, right at the bottom of the log the last 5 lines. Have you seen that one?

When I override sourceMaven to http://galasadev-cicsk8s.hursley.ibm.com/main/maven/obr, the build is successful and takes around 1 minute for clean and a few seconds for delta, so all seems okay then.

@jadecarino
Copy link
Contributor

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you to merge this in, I just wanted to comment the above as this issue might need addressing in general as it commonly occurs.

@techcobweb
Copy link
Contributor Author

techcobweb commented Nov 4, 2022

Happy for you to merge this in, I just wanted to comment the above as this issue might need addressing in general as it commonly occurs.

Is it raised as an issue yet ?
Are you saying that this is an intermittent problem ? Or happens in the tekton build process too ? or when does it happen ?
Will turning off --profile stop it ?
I wasn't seeing this...

@jadecarino
Copy link
Contributor

Lets chat on Monday, if you haven't seen this it might be an issue my end. If not, I'll raise an issue for it.

@techcobweb techcobweb merged commit 9cbca5b into main Nov 4, 2022
@techcobweb techcobweb deleted the javadoc-warning-fixes branch November 7, 2022 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants