This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Load properties prior to writing them out to reduce the race timing window length #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow length Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
|
Build successful |
Jimbo4794
reviewed
Mar 1, 2023
| @@ -154,6 +154,14 @@ public synchronized List<String> getNamespaces() { | |||
| * @throws FrameworkPropertyFileException | |||
| */ | |||
| public synchronized void delete(String key) throws FrameworkPropertyFileException { | |||
| // Make the current properties as close to the values in the file as | |||
| // we can. So when we write they are up-to-date. | |||
| if (observer!=null) { | |||
There was a problem hiding this comment.
Did you need to null check here? The observer is instantiated by the constructor and will throw an exception if unable to create.
There was a problem hiding this comment.
destroy() sets it to null, and some unit tests try setting properties after the destroy call, so I assumed it was supposed to handle it.
Jimbo4794
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com