Framework understands GALASA_HOME env var and system property.

[techcobweb]

Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com

This PR relates to galasa-dev/projectmanagement#1397

• Set of mock objects capable of mocking the underside of the framework init code.
• Broke the massive constructor (200+ lines) into smaller functions which can be unit tested in isolation.
• Less reliance on this.xxx in all methods, which made things very interlocked.
• Added IFileSystem to isolate the code from access to nio.filesystem. So file and folder create operations can be mocked-out.
• Added IEnvironment to isolate the code from System.getenv() and System.getProperty() calls.

[galasa-team]

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-394-9kdp5 for details. If you are unable to do so, please contact a member of the Galasa team.

[galasa-team]

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-394-568dw for details. If you are unable to do so, please contact a member of the Galasa team.

[galasa-team]

Build successful

[galasa-team]

Build successful

[galasa-team]

Build successful

[Jimbo4794]

Arron may have more suggestions still so dont take my approval as the only one. But looking through looks to make this a lot ore readable. As just discussed, there are a few areas like the location of Creds which could do with some more logging (trace).

But nice refactor assuming all working.

I didnt review much of the mocks but nice to see the tests

[galasa-team]

Build successful

[galasa-team]

Build successful

[Jimbo4794]

Approved subject to suggestions

[galasa-team]

Build successful