-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Co-authored-by: Jade Carino <jadecarino@users.noreply.github.com> Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Code Coverage is at 82% |
...alasa.framework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/ResultNames.java
Outdated
Show resolved
Hide resolved
...rk.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/ExtractQuerySort.java
Outdated
Show resolved
Hide resolved
...ork.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/QueryParameters.java
Outdated
Show resolved
Hide resolved
...api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/ServletErrorMessage.java
Outdated
Show resolved
Hide resolved
...mework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/routes/RunQueryRoute.java
Outdated
Show resolved
Hide resolved
...java/dev/galasa/framework/api/ras/internal/mocks/MockResultArchiveStoreDirectoryService.java
Outdated
Show resolved
Hide resolved
...ork.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/QueryParameters.java
Outdated
Show resolved
Hide resolved
...ork.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/QueryParameters.java
Outdated
Show resolved
Hide resolved
...rk.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/ExtractQuerySort.java
Outdated
Show resolved
Hide resolved
...lasa.framework.api.ras/src/test/java/dev/galasa/framework/api/ras/internal/TestRunQuery.java
Outdated
Show resolved
Hide resolved
...lasa.framework.api.ras/src/test/java/dev/galasa/framework/api/ras/internal/TestRunQuery.java
Show resolved
Hide resolved
...java/dev/galasa/framework/api/ras/internal/mocks/MockResultArchiveStoreDirectoryService.java
Outdated
Show resolved
Hide resolved
...ork.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/QueryParameters.java
Outdated
Show resolved
Hide resolved
...ork.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/commons/QueryParameters.java
Outdated
Show resolved
Hide resolved
Build successful |
1 similar comment
Build successful |
Co-authored-by: Eamonn Mansour <Eamonn.Mansour@ibm.com> Co-authored-by: Mike Cobbett <mike_cobbett@uk.ibm.com> Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-409-tvsd8 for details. If you are unable to do so, please contact a member of the Galasa team. |
Build successful |
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better! Just spotted one change we could make - approved assuming it will be addressed.
...mework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/routes/RunQueryRoute.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
...sa.framework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/TestClassesRas.java
Outdated
Show resolved
Hide resolved
...sa.framework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/TestClassesRas.java
Outdated
Show resolved
Hide resolved
...alasa.framework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/ResultNames.java
Outdated
Show resolved
Hide resolved
...alasa.framework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/ResultNames.java
Outdated
Show resolved
Hide resolved
...lasa.framework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/RequestorRas.java
Outdated
Show resolved
Hide resolved
...mework.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/routes/RunQueryRoute.java
Outdated
Show resolved
Hide resolved
...work.api.ras/src/main/java/dev/galasa/framework/api/ras/internal/common/QueryParameters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, ping me if Im not being clear or explaining why I think things, and we can make the changes together if you wish.
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to the changes we spoke about being delivered.
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Build successful |
No description provided.