Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

Savvas 82 age queries #409

Merged
merged 16 commits into from
May 24, 2023
Merged

Savvas 82 age queries #409

merged 16 commits into from
May 24, 2023

Conversation

KirbyKatcher
Copy link
Contributor

No description provided.

KirbyKatcher and others added 5 commits May 17, 2023 17:41
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Co-authored-by: Jade Carino <jadecarino@users.noreply.github.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@KirbyKatcher
Copy link
Contributor Author

Code Coverage is at 82%

openapi.yaml Outdated Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
@galasa-team
Copy link

Build successful

1 similar comment
@galasa-team
Copy link

Build successful

Co-authored-by: Eamonn Mansour <Eamonn.Mansour@ibm.com>
Co-authored-by: Mike Cobbett <mike_cobbett@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-framework-pr-409-tvsd8 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build successful

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build successful

Copy link
Member

@eamansour eamansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! Just spotted one change we could make - approved assuming it will be addressed.

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build successful

Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, ping me if Im not being clear or explaining why I think things, and we can make the changes together if you wish.

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@KirbyKatcher KirbyKatcher requested a review from techcobweb May 24, 2023 08:47
@galasa-team
Copy link

Build successful

Copy link
Contributor

@techcobweb techcobweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to the changes we spoke about being delivered.

Signed-off-by: Savvas Kyriacou <savvasky@uk.ibm.com>
@galasa-team
Copy link

Build successful

@KirbyKatcher KirbyKatcher merged commit 8a9ab51 into main May 24, 2023
@KirbyKatcher KirbyKatcher deleted the savvas-82-age-queries branch May 24, 2023 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants