-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable global options in a tool yaml file #26
Conversation
@mvdbeek if you have some time, can you look at this please? |
@bgruening I think this is really needed and hence glad to see it. I'd just suggest to include a link to the docs explaining those or add a one line comment about each (because for a deployer that's not very invested in the tool dev, the differences between the three options are not really clear). |
@afgane where should this documentation go? In the example yaml? |
That would probably be best. Alternatively, above each definition of the global var? (e.g., https://github.com/galaxyproject/ephemeris/pull/26/files#diff-3e2dc1314104230489feb0f417f2d40fR47) |
Maybe we should set repository_dependencies by default to true, to account for suites? Other than that looks good to me. |
Added some docs and changed the default value. Thanks for the review! |
Awesome - thanks a bunch @bgruening! |
I guess I should have been more explicit because what I meant by docs was to specify differences between tool, repository, and resolver dependencies... |
@afgane this are TS secrets no one knows exactly ;) |
That's how it feels every time I come cross them... BTW, I'm really glad to see this switch that happened here. |
This PR will enable global options in a tool yaml files. Means
can be specified as top arguments next to the Galaxy instance and API key. It will also change the default setting, to install resolver-dependencies and not tool-dependencies anymore.