Clean up the main() function #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@bgruening For what it is worth - I prefer this version to previous. I'm +1 on this as is but if you want to spend more time coming up with a best practice Python standard let me know. |
|
@jmchilton I'm fine with this. It was a little bit unexpected to have a main() function without parameter, I was just wondering if this is the best-practice or if there is anything else. |
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the current setup.py setup needs to have a clean main() function.
Anyone know what is the preferred Python way to handle such a setup? I have seen many projects that writes the
bin/*on there own.