Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error notification when a code generation command fails #113

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Display error notification when a code generation command fails #113

merged 3 commits into from
Feb 14, 2021

Conversation

davelopez
Copy link
Collaborator

This fixes #108

@davelopez davelopez added bug Something isn't working language server Related to the language server vscode extension Related to the VS Code extension labels Feb 14, 2021
@davelopez davelopez added this to the v0.4.0 milestone Feb 14, 2021
bgruening
bgruening approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davelopez for working on all of this!

@davelopez davelopez merged commit 847c23c into master Feb 14, 2021
@davelopez davelopez deleted the fix_#108 branch February 14, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
bug Something isn't working language server Related to the language server vscode extension Related to the VS Code extension
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Errors in code generation silently fail
2 participants
@davelopez @bgruening