Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xsd documentation hover #64

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Conversation

davelopez
Copy link
Collaborator

This PR fixes #63 by retrieving the documentation annotation from the XSD type definition when there is no direct annotation on the element itself. Now, most of the elements should show the correct documentation on hover.

Some of the type hints were consolidated across the related files.

Also, a couple of tests for this fix were added.

Retrieves the documentation text from the XSD element or the type
Test documentation retrieval from xsd definitions or types
The new Python extension in VSCode has changed the pythonPath parameter
@davelopez davelopez added bug Something isn't working language server Related to the language server paper-cut A trivially fixable usability bug labels Nov 19, 2020
@davelopez davelopez added this to the v0.2.1 milestone Nov 19, 2020
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@davelopez davelopez merged commit 26fe471 into master Nov 19, 2020
@davelopez davelopez deleted the fix-xsd-documentation-hover branch November 19, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server Related to the language server paper-cut A trivially fixable usability bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve element documentation on Hover returns 'No documentation available'
2 participants