Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose StoredWorkflowId in invocation API #11871

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

simonbray
Copy link
Member

What did you do?

  • Expose StoredWorkflowId in the invocation API in addition to WorkflowId
  • Allow use of the instance param for the index_invocations and invoke methods (for the others it was already supported). This allows the user to select whether they want to invoke / index workflows using the StoredWorkflowId or WorkflowId.

Why did you make this change?

Almost all interactions with the Galaxy API require the StoredWorkflowId, it's quite confusing (and not that useful) that accessing an invocation provides the WorkflowId. E.g. accessing an invocation, getting the workflow id and attempting to use it to re-invoke the workflow will fail (unless the two IDs are coincidentally the same).

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

For UI Components

  • I've included a screenshot of the changes

@github-actions github-actions bot added this to the 21.05 milestone Apr 20, 2021
@jmchilton jmchilton merged commit 9f8ce3d into galaxyproject:dev Apr 20, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@jmchilton
Copy link
Member

Awesome, this was definitely needed and I apologize to contributing to the confusion and inconsistency around these endpoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants