New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release release_23.0 branch: Bugs in Tool recommendation API call and its associated UI #15723
Comments
ping @dannon thank you! |
I looked into it a bit and found that in the file
if But, in Galaxy's central panel where recommendations are shown after any tool execution as a D3.js tree, it needs a lot of work - probably the entire JS script should be rewritten in the latest version of D3.js. I made changes locally in Any suggestions @dannon thanks! |
This PR fixes tool recommendation galaxyproject#15723 partially, only in the workflow editor
Fixes d3 JS tree for tool recommendation mentioned in galaxyproject#15723 PR against 23.0 on Galaxy main is open (galaxyproject#15852), but it may take some time to be merged. Can this PR be merged so that we can test it on the EU? All the lining tests are passing. Only one test fails but that's not related to this PR I think. ping @bgruening @ElectronicBlueberry thanks a lot!
Describe the bug
Bugs in Tool recommendation API call and its associated UI
Galaxy Version and/or server at which you observed the bug
Galaxy Version:
release_23.0
(https://github.com/galaxyproject/galaxy/tree/release_23.0)To Reproduce
Steps to reproduce the behavior:S1_File_ Transformer-based-tool-recommender.pdf
enable_tool_recommendations
totrue
, and uncommenttool_recommendation_model_path
andtopk_recommendations
attributes.Sort data in ascending or descending order
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '0') at VueComponent.renderD3Tree (ToolRecommendation.vue?9b7c:72:1) at eval (ToolRecommendation.vue?9b7c:60:1)
right arrow
) does not call its API (https://github.com/galaxyproject/galaxy/blob/release_23.0/lib/galaxy/webapps/galaxy/api/workflows.py#L598).Expected behavior
For the 3rd point, a tree should be shown with recommendations.
For the 4th point, a popover should be shown with a list of recommendations.
Screenshots to show issues/errors
Thanks a lot!
The text was updated successfully, but these errors were encountered: