Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release release_23.0 branch: Bugs in Tool recommendation API call and its associated UI #15723

Closed
anuprulez opened this issue Mar 7, 2023 · 2 comments

Comments

@anuprulez
Copy link
Member

Describe the bug
Bugs in Tool recommendation API call and its associated UI

Galaxy Version and/or server at which you observed the bug
Galaxy Version: release_23.0 (https://github.com/galaxyproject/galaxy/tree/release_23.0)

To Reproduce
Steps to reproduce the behavior:S1_File_ Transformer-based-tool-recommender.pdf

  1. Enable tool recommendation feature - In Galaxy.yml file, set enable_tool_recommendations to true, and uncomment tool_recommendation_model_path and topk_recommendations attributes.
  2. Upload a tabular file and run a tool such as Sort data in ascending or descending order
  3. The tool recommendations section in the Galaxy's central panel show the following error - Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '0') at VueComponent.renderD3Tree (ToolRecommendation.vue?9b7c:72:1) at eval (ToolRecommendation.vue?9b7c:60:1)
  4. Further, in the workflow editor, hover action on tool recommendation icon on any toolbox (right arrow) does not call its API (https://github.com/galaxyproject/galaxy/blob/release_23.0/lib/galaxy/webapps/galaxy/api/workflows.py#L598).
  5. Similar issues persist in Galaxy EU in the newest release (release_22.05_eu)

Expected behavior
For the 3rd point, a tree should be shown with recommendations.

cutadapt

For the 4th point, a popover should be shown with a list of recommendations.

fastp_plost_one

Screenshots to show issues/errors

tr2

tr1

Thanks a lot!

@anuprulez
Copy link
Member Author

ping @dannon thank you!

@dannon dannon self-assigned this Mar 7, 2023
@anuprulez
Copy link
Member Author

anuprulez commented Mar 21, 2023

I looked into it a bit and found that in the file client/src/components/Workflow/Editor/Node.vue at

<Recommendations
       v-if="popoverShow"
       :step-id="id"
       :datatypes-mapper="datatypesMapper"
       @onCreate="onCreate" />

if v-if="popoverShow" is removed, the recommendations work fine in the workflow editor (image below)

working recomeen

But, in Galaxy's central panel where recommendations are shown after any tool execution as a D3.js tree, it needs a lot of work - probably the entire JS script should be rewritten in the latest version of D3.js. I made changes locally in release_23_0 branch.

Any suggestions @dannon thanks!

anuprulez added a commit to anuprulez/galaxy that referenced this issue Mar 22, 2023
This PR fixes tool recommendation galaxyproject#15723 partially, only in the workflow editor
anuprulez added a commit to usegalaxy-eu/galaxy that referenced this issue Mar 28, 2023
Fixes d3 JS tree for tool recommendation mentioned in galaxyproject#15723

PR against 23.0 on Galaxy main is open (galaxyproject#15852), but it may take some time to be merged. Can this PR be merged so that we can test it on the EU? All the lining tests are passing. Only one test fails but that's not related to this PR I think.

ping @bgruening @ElectronicBlueberry  thanks a lot!
@mvdbeek mvdbeek closed this as completed in 3c6f93d Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants