Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galaxy should refuse to load tool if tool is too new (tool profiles) #2086

Closed
2 of 3 tasks
hexylena opened this issue Apr 5, 2016 · 6 comments
Closed
2 of 3 tasks

Galaxy should refuse to load tool if tool is too new (tool profiles) #2086

hexylena opened this issue Apr 5, 2016 · 6 comments
Assignees
@davebx @martenson @mvdbeek
Labels
area/tools friendliness/intermediate kind/enhancement
Milestone
17.09

Comments

@hexylena
Copy link
Member

hexylena commented Apr 5, 2016 •
edited by mvdbeek

@hexylena hexylena added this to the 16.07 milestone Apr 5, 2016
@hexylena hexylena mentioned this issue Apr 5, 2016
Closed
5 tasks
@martenson
Copy link
Member

toolshed should show warnings

Galaxy should show warnings? (this is during tool installation right?)

@hexylena
Copy link
Member Author

hexylena commented Apr 5, 2016

Yes, that's the correct phrasing. (Sorry, I woke up 5 minutes after the conference call started this morning)

@martenson
Copy link
Member

@erasche sorry we woke you up and thanks for joining! 👏

@martenson martenson modified the milestones: 16.10, 16.07 Jul 27, 2016
@hexylena hexylena changed the title schema version 2 remaining issues. Galaxy should show warnings if tool is too new Nov 16, 2016
@hexylena hexylena changed the title Galaxy should show warnings if tool is too new Galaxy should show warnings if tool is too new (tool profiles) Nov 16, 2016
@martenson martenson modified the milestones: 17.01, 16.10 Nov 16, 2016
@martenson martenson modified the milestones: 17.05, 17.01 Jan 12, 2017
@martenson martenson modified the milestones: 17.09, 17.05 Apr 26, 2017
@mvdbeek mvdbeek mentioned this issue Aug 7, 2017
Closed
@mvdbeek
Copy link
Member

mvdbeek commented Aug 7, 2017 •
edited

From #4361:

This came up during the GCC (and the last GCC as well, I think ...).
Tool authors should be able to specify a minimum version of galaxy that is required to run a tool.
We already have the profile attribute, but currently galaxy instances will happily load tools regardless of the tool profile version, and the tool shed will not block or notify admins that a minimum galaxy version is required.

We can probably not rely on this retroactively, but we should have a mechanism in place so that in the future we can change certain defaults.

So what I would propose is that galaxy refuses to load a tool with a profile version higher than the running galaxy version, and that the toolshed installation process will inspect a repository for the minimum required galaxy version.

@mvdbeek mvdbeek self-assigned this Aug 7, 2017
@mvdbeek mvdbeek changed the title Galaxy should show warnings if tool is too new (tool profiles) Galaxy should refuse to load tool if tool is too new (tool profiles) Aug 7, 2017
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Aug 7, 2017
@mvdbeek
Stop loading tools that require a newer galaxy
3a848b1 
We look at a tools profile attribute, and if it is too new we will not
load the tool. This is a first step towards
galaxyproject#2086
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Aug 7, 2017
@mvdbeek
Stop loading tools that require a newer galaxy
b19640b 
We look at a tools profile attribute, and if it is too new we will not
load the tool. This is a first step towards
galaxyproject#2086
@mvdbeek mvdbeek mentioned this issue Aug 7, 2017
Merged
@mvdbeek
Copy link
Member

mvdbeek commented Aug 8, 2017

With #4386 and #4382 I think we're pretty much there. We don't allow loading tools that are too new, and we display the minimum required galaxy version before installing the tool. We don't prevent the installation of the repository yet, but I'm not sure that's really required.

@jmchilton
Copy link
Member

Wonderful - thanks for the additional @mvdbeek - this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davebx davebx

@martenson martenson

@mvdbeek mvdbeek

Labels
area/tools friendliness/intermediate kind/enhancement
Projects
None yet
Milestone
17.09
Development

No branches or pull requests
5 participants
@jmchilton @hexylena @davebx @martenson @mvdbeek