[21.05] ITs on Kubernetes #11383
[21.05] ITs on Kubernetes #11383
Conversation
|
Great! So, this is not relying then on the GIE proxy mechanism to re-route things? |
|
Nope, no proxy mechanism, just requires an ingress controller in the cluster. Relies on the job runner to create and cleanup the Service/Ingress pair along with the IT job |
almahmoud
force-pushed
the
k8s_runner_its
branch
from
814f8b7
to
74acf16
Compare
almahmoud
force-pushed
the
k8s_runner_its
branch
from
74acf16
to
283bf2f
Compare
lib/galaxy/config/__init__.py
Outdated
| @@ -817,6 +817,7 @@ def _process_config(self, kwargs): | |||
| self.interactivetools_map = self._in_root_dir(kwargs.get("interactivetools_map", self._in_data_dir("interactivetools_map.sqlite"))) | |||
| self.interactivetools_prefix = kwargs.get("interactivetools_prefix", "interactivetool") | |||
| self.interactivetools_proxy_host = kwargs.get("interactivetools_proxy_host", None) | |||
There was a problem hiding this comment.
This is not necessary: it's processed automatically
There was a problem hiding this comment.
I didn't add them, they were here from the original IT work. If I'm understanding correctly, you're suggesting they should all be removed from here and just added to the schema? (at least interactivetools_prefix is not in the schema already)
| @@ -610,4 +798,18 @@ def finish_job(self, job_state): | |||
| log.warning("More than one job matches selector. Possible configuration error" | |||
| " in job id '%s'", job_state.job_id) | |||
| job = Job(self._pykube_api, jobs.response['items'][0]) | |||
| if job_state.job_wrapper.tool.tool_type == "interactive": | |||
There was a problem hiding this comment.
I don't know for sure - but I think I was trying to use job_state.job_wrapper.tool.ports to determine if we need to expose ports instead of tool type being interactive.
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
…into k8s_runner_its
Enabling running ITs with Service and Ingress without reverse proxy when Galaxy is running on k8s. Started with k8s runner cause more familiar with it but plan is to port to pulsar. Still very WIP, but the basics are there:
