[22.01] Fix UnboundLocalError in sort collection tool

[davelopez]

Should fix #13302

I tried to add a test to the Sort Collection tool like:

<test expect_failure="true">
    <!-- test invalid sort_type-->
    <param name="input">
        <collection type="list">
            <element name="element_1" value="simple_line_alternative.txt"/>
            <element name="element_2" value="simple_line.txt"/>
        </collection>
    </param>
    <param name="sort_type" value="unknown"/>
</test>

But for some reason, the test fails with Expected job to fail but Galaxy indicated the job successfully completed. Probably this is not the correct way of testing the wrong parameter?

Bonus Points

Also fixes an error message text with swapped placeholders.

How to test the changes?

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.

License

• I agree to license these contributions under Galaxy's current license.
• I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to galaxy-committers@lists.galaxyproject.org.

[jdavcs]

LGTM!

[jmchilton]

Presumably the API is picking a default for the sort type in this testing situation that it doesn't in some other invocation of the tool. There is a bunch of testing specific magic in there unfortunately.

[davelopez]

Ohh I see, that makes sense then, thank you @jmchilton and @ic4f for the review and the explanation!