Unify and Abstract Code for Checking if File Looks Like a Tool #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tool XML files. A single abstraction will allow toolbox and planemo to deal with other kinds of tools in the future, and the stronger preconditions should eliminate some busy error logging when monitoring a tool directory.
Default is off obviously, so for instance the tool shed will never think unsupported beta tools are real tools.
Order of inputs and outputs in Galaxy is important, so preserve this order if using dictionary-style (both available) for inputs and/or outputs.
jmchilton
force-pushed
the
looks_like_a_tool
branch
from
32fb9fa
to
b7b8f09
Compare
jmchilton
added
kind/enhancement
kind/refactoring
|
I like this a lot, I will give it another shot of review later today but am close to merging it. |
|
👍 |
|
looks like a looks_like_a_tool to me, thanks @jmchilton |
martenson
added a commit
that referenced
this pull request
Dec 22, 2015
Unify and Abstract Code for Checking if File Looks Like a Tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolshed, toolbox, and planemo all used different methods for quickly checking if a file is supposed to look like a tool previously. This unifies them into a single
looks_like_a_toolmethod. Additionally, this makes the method more correct by handling the "enable_beta_tool_formats" config option.This PR also pulls in some some updates to the dictified representation of tools from my downstream work on dynamically splitting and merging collections using datatype methods. Even if we never expose the YAML format externally - that use of dynamically building a tool per datatype demonstrates the utility of allowing Galaxy to use the format internally. The real utility though is one of code design, helping ensure there is a strict differentiation between the layout of tools in a file and Galaxy's abstract description (the Tool class).