Fix download collection button in history panel. #13690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
reviewed
Apr 7, 2022
nsoranzo
reviewed
Apr 11, 2022
There was a problem hiding this comment.
These proposed changes should implement @davelopez's suggestion, and fix a failing BioBlend test for me.
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
nsoranzo
reviewed
Apr 13, 2022
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
nsoranzo
approved these changes
Apr 13, 2022
bgruening
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading collections from the classic history panel seems broken in dev. I assume the FastAPI endpoint was broken-ish and then we dropped the WSGI backups and the functionality broke.
I needed to drop the tags in order to not get a 404 and I needed a signature with history_id in it in order to not get a validation error. So this is probably not the best way - just the fastest? @davelopez any ideas?
How to test the changes?
(Select all options that apply)
License