Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the swift integration tests that are using some minio container #14008

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

bgruening
Copy link
Member

The minio container yields an error with /tmp/data. Maybe that fixes the integration tests?

bag@bag:~$ docker run -p 9000:9000 -i -t  minio/minio:latest server /tmp/data
Formatting 1st pool, 1 set(s), 1 drives per set.

API: SYSTEM()
Time: 09:05:06 UTC 06/03/2022
Error: Disk `/tmp/data` is part of root disk, will not be used (*errors.errorString)
       8: internal/logger/logger.go:278:logger.LogIf()
       7: cmd/erasure-sets.go:1243:cmd.markRootDisksAsDown()
       6: cmd/format-erasure.go:798:cmd.initFormatErasure()
       5: cmd/prepare-storage.go:198:cmd.connectLoadInitFormats()
       4: cmd/prepare-storage.go:282:cmd.waitForFormatErasure()
       3: cmd/erasure-server-pool.go:66:cmd.newErasureServerPools()
       2: cmd/server-main.go:668:cmd.newObjectLayer()
       1: cmd/server-main.go:518:cmd.serverMain()
Formatting 1st pool, 1 set(s), 1 drives per set.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@bgruening
Copy link
Member Author

Mh, different failures. I think this has fixed the swift failures, but there are new ones.

FAILED test/integration/test_history_import_export.py::ImportExportHistoryOutputsToWorkingDirIntegrationTestCase::test_import_export_nested_collection

@mvdbeek mvdbeek merged commit 2c30acb into galaxyproject:dev Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This PR was merged without a "kind/" label, please correct.

@bgruening bgruening deleted the swift_integration_tests branch June 3, 2022 10:16
@dannon
Copy link
Member

dannon commented Jun 3, 2022

@bgruening I saw that same failure in another PR, it's not new with this swap. Thanks for fixing this!

@nsoranzo nsoranzo modified the milestones: 22.09, 22.05 Jun 3, 2022
@nsoranzo nsoranzo changed the title try fixing the swift integration tests that are using some minio container Fix the swift integration tests that are using some minio container Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants