Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More API tests for the tool shed. #14553

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

jmchilton
Copy link
Member

Continue working toward a set of pydantic models to rapidly move toward FastAPI/OpenAPI also.

How to test the changes?

(Select all options that apply)

License

Continue working toward a set of pydantic models to rapidly move toward FastAPI/OpenAPI also.
@@ -659,7 +659,7 @@ def handle_repository(trans, rmm, repository, results):
@web.legacy_expose_api
def reset_metadata_on_repository(self, trans, payload, **kwd):
"""
PUT /api/repositories/reset_metadata_on_repository
POST /api/repositories/reset_metadata_on_repository
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the API endpoint - this is just a typo in the docs I'm fixing.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the framework test failure seems related
Never mind, the failure is unrelated and fails in other PRs... 🤔

@bgruening bgruening merged commit 78960c6 into galaxyproject:dev Sep 10, 2022
@jmchilton
Copy link
Member Author

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants