[16.01] Update help text rST note/warning/error box styling for change in div class from toolHelpBody to ui-form-help. #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class from toolHelpBody to ui-form-help.
martenson
added a commit
that referenced
this pull request
Feb 8, 2016
[16.01] Update help text rST note/warning/error box styling for change in div class from toolHelpBody to ui-form-help.
|
@natefoo changes in base.less should only result in additional changes in base.css so I assume that the additional JS files are forgotten client build |
|
I was wondering about that as well, but it looks like these specific files update more frequently (look at their histories). If they're pulled from external sources that would explain it? Sorry, I don't know enough about the client code to comment intelligently here. |
|
Differing dependency versions have been known to pack/bundle the files slightly differently in the past, and that could explain it as well. |
|
@dannon but not functionally differently I hope? |
|
@martenson Yay github email delay :) No, they still both seemed to work fine, just slightly different packing algorithms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression pointed out by @bgruening in #685