Revise tool parameter handling, remove redundancies #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
revise_states_000
branch
8 times, most recently
from
4a593aa
to
e795b9d
Compare
|
@galaxybot test this |
|
Looks like there are some legitimate failures in the test cases, if the problem just becomes test cases using deprecated features though let me know I can update the tests. |
guerler
force-pushed
the
revise_states_000
branch
16 times, most recently
from
85112c4
to
bd6c1fe
Compare
|
Looks good to me: +1 |
|
No worries and thanks a lot for the comments. |
guerler
force-pushed
the
revise_states_000
branch
4 times, most recently
from
579d6ce
to
f341ca3
Compare
guerler
force-pushed
the
revise_states_000
branch
from
f341ca3
to
5041c80
Compare
|
I tested composite file uploads within a docker image and i did not notice anything odd. |
|
Thanks this is a substantial cleanup and simplification of various complex things - this should set the stage for awesome things down the road. |
jmchilton
added a commit
that referenced
this pull request
Feb 19, 2016
Revise tool parameter handling, remove redundancies
|
@guerler it is merged, bot will ignore it I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1572 and #115 and our ongoing effort to unify the tool parameter handling, remove hacks, legacy handling and redundancies.
https://github.com/galaxyproject/galaxy/pull/1711/files#diff-1bef786a2b2ea704c1748e41cd25dd33L2781
https://github.com/galaxyproject/galaxy/pull/1711/files#diff-c2872901d34ca0c09ded74872356dd7bL14
https://github.com/galaxyproject/galaxy/pull/1711/files#diff-c2872901d34ca0c09ded74872356dd7bR60
https://github.com/galaxyproject/galaxy/pull/1711/files#diff-9baf995401cfeb779edf8731ebaf0d2dL1649
https://github.com/galaxyproject/galaxy/pull/1711/files#diff-5cab48d5f01fec3fa30d17f4bf5d1848L1048
guerler@050adad