History refactors #17353
Merged
History refactors #17353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itisAliRH
force-pushed
the
history-refactors
branch
from
029f4c6
to
b3380fa
Compare
davelopez
reviewed
Feb 8, 2024
client/src/components/History/Content/Collection/CollectionProgress.test.ts
Outdated
Show resolved
Hide resolved
client/src/components/History/Content/Dataset/DatasetActions.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/Content/Dataset/DatasetActions.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentCollection/CollectionDetails.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentCollection/CollectionNavigation.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentHistory/HistoryOperations/HistoryOperations.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentHistory/HistoryOperations/DefaultOperations.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentHistory/HistoryOperations/OperationErrorDialog.vue
Outdated
Show resolved
Hide resolved
Closed
4 tasks
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
davelopez
reviewed
Feb 13, 2024
client/src/components/History/Content/Collection/CollectionDescription.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/Content/Dataset/DatasetActions.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/Content/Dataset/DatasetDownload.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com> Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
davelopez
approved these changes
Feb 15, 2024
|
Thanks a lot @itisAliRH! |
|
This PR was merged without a "kind/" label, please correct. |
bgruening
added
the
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors most of the history and history-related components to CompositionAPI and typescript and more logic and icon import improvements. The remaining components will be refactored in a follow-up PR.
ref: #15686
List of the changed files
api/histories.tscomponents/History/Content/Collection/CollectionDescription.vuecomponents/History/Content/Collection/CollectionProgress.test.tscomponents/History/Content/Collection/CollectionProgress.vuecomponents/History/Content/Dataset/DatasetActions.vuecomponents/History/Content/Dataset/DatasetDownload.test.tscomponents/History/Content/Dataset/DatasetDownload.vuecomponents/History/Content/Dataset/mixins.jscomponents/History/CurrentCollection/CollectionDetails.vuecomponents/History/CurrentCollection/CollectionNavigation.vuecomponents/History/CurrentHistory/HistoryCounter.vuecomponents/History/CurrentHistory/HistoryDetails.vuecomponents/History/CurrentHistory/HistoryEmpty.vuecomponents/History/CurrentHistory/HistoryMessages.vuecomponents/History/CurrentHistory/HistoryNavigation.test.tscomponents/History/CurrentHistory/HistoryNavigation.vuecomponents/History/CurrentHistory/HistoryOperations/DefaultOperations.vuecomponents/History/CurrentHistory/HistoryOperations/HistoryOperations.vuecomponents/History/CurrentHistory/HistoryOperations/OperationErrorDialog.vuecomponents/History/CurrentHistory/HistoryOperations/SelectionChangeWarning.vuecomponents/History/CurrentHistory/HistoryOperations/SelectionStatus.test.tscomponents/History/CurrentHistory/HistoryOperations/SelectionStatus.vuecomponents/History/CurrentHistory/PreferredStorePopover.vuecomponents/History/CurrentHistory/SelectPreferredStore.test.tscomponents/History/CurrentHistory/usesDetailedHistoryMixin.jscomponents/History/Export/ExportOptions.vuecomponents/History/HistoryPublished.vuecomponents/History/HistoryPublishedList.vuecomponents/History/Index.vuecomponents/History/Layout/DetailsLayout.vuecomponents/History/Modals/CopyModal.vuecomponents/History/Multiple/MultipleViewItem.vuecomponents/History/services.jscomponents/History/services.tsentry/analysis/App.vuestores/userStore.tsutils/navigation/navigation.ymlclient/tests/jest/helpers.js(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License