Pulsar-As-A-Dependency #2052
Merged
Pulsar-As-A-Dependency #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulsar's setup.py has been parameterized to allow it build a special wheel that doesn't depend on galaxy-lib (galaxyproject/pulsar@ce9d4f9) and instead expects it to come from the environment. This special dependency has been published to PyPI here (https://pypi.python.org/pypi/pulsar-galaxy-lib) and added to StarForge here (galaxyproject/starforge#79). These are now available on wheels.galaxyproject.org. In addition to removing the source dirctories - I have removed doc and CI references to these directories.
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulsar's setup.py has been parameterized to allow it build a special wheel that doesn't depend on galaxy-lib (galaxyproject/pulsar@ce9d4f9) and instead expects it to come from the environment.
This special dependency has been published to PyPI here (https://pypi.python.org/pypi/pulsar-galaxy-lib) and added to StarForge here (galaxyproject/starforge#79). These are now available on wheels.galaxyproject.org.
In addition to removing the source dirctories - I have removed doc and CI references to these directories.
Additonally, 46afedc contains a Pulsar fix for #1688.