-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an Embedded Pulsar Job Runner #2057
Conversation
Pulsar's setup.py has been parameterized to allow it build a special wheel that doesn't depend on galaxy-lib (galaxyproject/pulsar@ce9d4f9) and instead expects it to come from the environment. This special dependency has been published to PyPI here (https://pypi.python.org/pypi/pulsar-galaxy-lib) and added to StarForge here (galaxyproject/starforge#79). These are now available on wheels.galaxyproject.org. In addition to removing the source dirctories - I have removed doc and CI references to these directories.
For anyone unclear on why this is cool, this comment from the sample job conf explains it:
In other words, you get all of Pulsar's rewriting and staging functionality directly in Galaxy (it can't stage to remote resources, but it can stage all of a job's necessary files to/from a scratch filesystem). |
Awesome! 💯 |
compute). --> | ||
<!-- Specify a complete description of the Pulsar app | ||
to create. Currently this configuration (if set) | ||
must create exactly on job manager. For more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/on/one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, will open a PR with fix. Thanks.
This implements an initial embedded Pulsar job runner (the last item on #1378 and outlined in this Trello card). See documentation updates to
job_conf.xml.sample_advanced
for information on configuration.In addition to the commit that implements this, PR #2052 is included (since this work builds on that) as well smaller doc and import cleanups for the pulsar job runner code in
lib/galaxy/jobs/runners/pulsar.py
.