Add conda search function #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +70,7 @@ def execute(cmds): | |||
|
|
|||
| Return the standard output if the commands are successful | |||
| """ | |||
| return _wait(cmds, shell=False) | |||
| return __wait(cmds, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE) | |||
There was a problem hiding this comment.
Change back __wait() to _wait() ? You haven't changed the function name below and double underscore should be used only if you need name mangling (see https://stackoverflow.com/questions/1301346/the-meaning-of-a-single-and-a-double-underscore-before-an-object-name-in-python ).
There was a problem hiding this comment.
This was a bad merge, sorry. Will fix now.
|
👍 |
martenson
added
kind/enhancement
status/review
area/framework
area/admin
area/tool-framework
and removed
triage
area/framework
labels
|
thanks @bgruening , will try to make use of it! |
|
@martenson thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is useful to check in advance if a package is available.
I hope this can be used by @martenson in #2250 to display cute little anaconda icons during the tool installation.
Something similar could be done for the Docker.