Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda search function #2395

Merged
merged 3 commits into from May 25, 2016

Conversation

Projects
None yet
5 participants
@bgruening
Copy link
Member

commented May 23, 2016

This function is useful to check in advance if a package is available.
I hope this can be used by @martenson in #2250 to display cute little anaconda icons during the tool installation.

Something similar could be done for the Docker.

@galaxybot galaxybot added the triage label May 23, 2016

@galaxybot galaxybot added this to the 16.07 milestone May 23, 2016

@@ -70,7 +70,7 @@ def execute(cmds):
Return the standard output if the commands are successful
"""
return _wait(cmds, shell=False)
return __wait(cmds, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE)

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo May 24, 2016

Member

Change back __wait() to _wait() ? You haven't changed the function name below and double underscore should be used only if you need name mangling (see https://stackoverflow.com/questions/1301346/the-meaning-of-a-single-and-a-double-underscore-before-an-object-name-in-python ).

This comment has been minimized.

Copy link
@bgruening

bgruening May 24, 2016

Author Member

This was a bad merge, sorry. Will fix now.

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 25, 2016

👍

@martenson

This comment has been minimized.

Copy link
Member

commented May 25, 2016

thanks @bgruening , will try to make use of it!

@martenson martenson merged commit 81702e7 into galaxyproject:dev May 25, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member Author

commented May 31, 2016

@martenson thanks! :)

@bgruening bgruening deleted the bgruening:conda_search branch May 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.