Bring Galaxy, reports, and shed run scripts in sync. #2837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- They now uniformly handle server option processing. - Reports and Tool Shed now respect many new and important options such as --skip_venv. - Reports and Tool Shed now do extra checking around Python version that Galaxy does. In addition to improving the reports and tool shed startup scripts and reducing cognative load with respect to option handling, this is an important pre-condition to us being able us to switch on uwsgi by default for all three services simultaneously without a bunch of copy and pasting.
jmchilton
added
kind/enhancement
kind/refactoring
|
Includes #2836 but that should disappear once that PR is merged I believe. |
Initial outline of allowing launch via uwsgi.
These were removed from Galaxy's config a while ago.
|
This seems to break (at least) reports running for me. With reports running locally (from dev), After killing it manually and trying to relaunch (from this branch) |
|
Thanks for the review @dannon - I'll fix and reopen. |
|
@jmchilton Sounds good. (or, really, it'd be fine to fix them here on this branch to preserve the context, but totally up to you) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip_venv.In addition to improving the reports and tool shed startup scripts and reducing cognative load with respect to option handling, this is an important precondition to us being able us to switch on uwsgi by default for all three services simultaneously without a bunch of copy and pasting.