Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethercalc Interactive Environment #3699

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Conversation

shiltemann
Copy link
Member

Hi All,

I've made an interactive environment for the Ethercalc spreadsheet application.

The corresponding docker definition can be found here: https://github.com/shiltemann/ethercalc-galaxy-ie

This will run on any tabular or csv file, load this dataset into Ethercalc, and upon save will give the option of saving in either of those two formats, and will automatically save an audit trail to the history as well, recording all the edits made.

Let me know what you think, and any comments/suggestions :)

ping @bgruening @erasche

image

image

image

@hexylena
Copy link
Member

hexylena commented Mar 2, 2017

Woah, an audit trail. That's really really awesome!

@shiltemann shiltemann changed the title Ethercalc Interactive Envrionment Ethercalc Interactive Environment Mar 2, 2017
@galaxybot galaxybot added this to the 17.05 milestone Mar 2, 2017
@blankenberg
Copy link
Member

awesome :)

@hexylena
Copy link
Member

hexylena commented Mar 3, 2017

Overall:

  • This is awesome! I've wanted an ethercalc IE forever. No more need to (download, change a single cell, re-upload), it is so much easier to edit "in place" so to speak. I am getting to the point of "why leave galaxy for the desktop ever".
  • I really love the audit trail functionality, that makes the inner functional programmer in me quite happy.

Architectural:

  • The container redirects to galaxy once the dataset is saved, is it possible to disable this behavior? While this neatly solves the "unrefreshed history" problem, it's a suboptimal UX to be forced to leave their work just because they want to save/checkpoint their work. If this can be fixed (or we know there is no way to fix it), this has my 👍

Nitpicks:

  • The save button is hard to find, but this is an upstream problem. Nothing you can reasonably do there.

@shiltemann
Copy link
Member Author

shiltemann commented Mar 3, 2017

thanks for testing :)

huh, it doesn't redirect to galaxy upon save for me, will have to look into that..

Edit: seems to happen when serving from subdirectory

@mvdbeek
Copy link
Member

mvdbeek commented Mar 3, 2017

That does look awesome!

@bgruening
Copy link
Member

I remember that ethercalc was one of our first ideas after Jupyter and RStudio, so this is great! Big 👍 !

As usual I'm a little bit worried about reproducibility here, but everyone Admin is able to decide this on their own.

Thanks Saskia, see you soon!

@shiltemann
Copy link
Member Author

@bgruening it is actually possible to replay those audit trail commands via the API, so was thinking of trying to make a tool that takes a tabular/csv file and an audit trail and replays the actions on top of the input file, that way it could also be used in workflows, what do you think? (you can use docker images in tools right?)

@hexylena
Copy link
Member

Ok, @shiltemann has fixed the nested/redirection issue in the container. All looks good now! 👍

@hexylena hexylena merged commit 18a26c5 into galaxyproject:dev Mar 24, 2017
@bgruening
Copy link
Member

Nice!!!

@nekrut
Copy link
Contributor

nekrut commented Mar 25, 2017

@natefoo @martenson : can we enable this on test asap? this truly saves a lot of issues that are too difficult for people to do with Jupyter
@shiltemann - this is awesome

@CicoZhang
Copy link

Wow! Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants